Enhance SamplingShaper so it can work on low order Blueprint meshes#1875
Open
BradWhitlock wants to merge 93 commits into
Open
Enhance SamplingShaper so it can work on low order Blueprint meshes#1875BradWhitlock wants to merge 93 commits into
BradWhitlock wants to merge 93 commits into
Conversation
…s in shaping driver for Blueprint meshes.
BradWhitlock
requested review from
Arlie-Capps,
bmhan12,
jcs15c,
kennyweiss and
rhornung67
June 16, 2026 23:36
…github.com:llnl/axom into feature/whitlock/sampling_low_order_blueprint_mesh
…ing. Also move some times and add a new one.
…github.com:llnl/axom into feature/whitlock/sampling_low_order_blueprint_mesh
jcs15c
reviewed
Jul 15, 2026
| return it->second; | ||
| } | ||
|
|
||
| void compute_interpolatory_weights(const axom::Array<double>& nodes, |
Contributor
There was a problem hiding this comment.
I think this method could use a brief doxygen header to explain what it does, even if it isn't user-facing.
jcs15c
reviewed
Jul 15, 2026
| for(int npts = 1; npts <= maxNpts; ++npts) | ||
| { | ||
| const auto rule = getRule(npts); | ||
| const int exactDegree = getExactDegree(npts); |
Contributor
There was a problem hiding this comment.
Now that there's a lot of quadrature rules to keep track of, do you think it's generally useful enough to have a helper function like get_exact_degree(numerics::QuadartureType, npts)? Even if it isn't necessary to actually execute it most of the time, its source code could provide a useful compendium of which rules evaluate which order polynomials.
Member
Author
There was a problem hiding this comment.
I had codex move code into a get_exact_degree helper function and update the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1692 so the
quest::SamplingShapercan operate on Blueprint low order meshes.SamplingShaperMFEM state into a state object that can be used among helper routinesBlueprintStateobject to support Blueprint stateSamplingShapercan be built when either MFEM or Conduit (or both) are present -- enables a shaper that works without MFEMconduit::Nodeor viasidre::Group.