Bugfix: CI jobs should fail if any unit test fails - #1920
Draft
kennyweiss wants to merge 2 commits into
Draft
Conversation
Run the `make test` command through `or_die` to exit with a non-zero status if any test fails.
… scope This is an attempt to fix failing CI in docker plans using shared build and gcc. Some quest_inout tests are failing w/ memory corruption due to bad destruction order w/ slic::finalize.
kennyweiss
force-pushed
the
bugfix/kweiss/docker-ci
branch
from
July 17, 2026 06:46
6b48d4e to
fa4d770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testwas not run throughor_die-- specifically some
quest_inout_interface*tests are failing in the shared gcc@13.3.1 jobs-- these tests have been failing in this config since at least April 2026, and our logs don't go back further
See: https://github.com/llnl/axom/actions/runs/25020134802/job/73280084010
Steps:
or_dietomake_testor_dietorun_benchmarksScreenshot
from: https://github.com/llnl/axom/actions/runs/27728595865/job/82030406017?pr=1882