Update containment regression baselines after bugfix for points on/near surface - #39
Merged
Merged
Conversation
…taset After modifying InOutOctree to return "inside" for points on the surface (or within the welding threshold distance to the surface).
…edron dataset After modifying InOutOctree to return "inside" for points on the surface (or within the welding threshold distance to the surface). Also tightens the bounding box for this test since it was too loose, and updates the tetrahedron_31 dataset to the same query box.
…sphere dataset After modifying InOutOctree to return "inside" for points on the surface (or within the welding threshold distance to the surface).
kennyweiss
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
jcs15c,
publixsubfan,
rhornung67 and
white238
July 10, 2026 01:13
rhornung67
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to llnl/axom#1909
which addresses this issue: llnl/axom#611
This PR updates our regression baselines for the inout and signed distance queries after a bugfix for how we treat query points that are on the surface (or within the vertex welding threshold of the surface).
The containment results still match the signs of the signed distances results (which did not change).
Differences were of the form:
i.e. the distances are negligible and the disagreements are due to fixing our convention for points on or extremely close to the surface.
I also changed the query bounding box for the tetrahedron tests from
{(-5,-5,-5), {5,5,5)}to{(-1.5,-1.5,-1.5), {1.5,1.5,1.5)}since the tetrahedron lies in the cube{(-1,-1,-1), {1,1,1)}, so most query points from the original were far outside the mesh bounding box.