Add clr and fil support in incremental evaluator before main loop - #698
Merged
Conversation
ckrause
reviewed
Jun 17, 2026
ckrause
reviewed
Jun 20, 2026
ckrause
left a comment
ckrause
left a comment
Contributor
There was a problem hiding this comment.
The logic is correct overall. A few minor things to clean up before merging, and please also update the CHANGELOG.
| if (bounds.first == Number::INF || bounds.second == Number::INF) { | ||
| if (error_code) { | ||
| *error_code = ErrorCode::MEMORY_OP_SOURCE_INVALID; | ||
| } |
Contributor
There was a problem hiding this comment.
All three validation failures (non-constant source, infinite bounds, range too large) use MEMORY_OP_SOURCE_INVALID. The last case is semantically different — consider a distinct error code or at least a comment to distinguish it.
Contributor
Author
There was a problem hiding this comment.
Also see L253-L276
Contributor
Author
|
Changelog is updated |
ckrause
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
clrandfilsupport in incremental evaluator before main loop