Skip to content

Fix an overflow bug in Mutator::mutateCopiesConstants - #701

Merged
ckrause merged 3 commits into
loda-lang:mainfrom
loader3229:patch-6
Jun 26, 2026
Merged

Fix an overflow bug in Mutator::mutateCopiesConstants#701
ckrause merged 3 commits into
loda-lang:mainfrom
loader3229:patch-6

Conversation

@loader3229

@loader3229 loader3229 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix an overflow bug in Mutator::mutateCopiesConstants
In Mutator::mutateCopiesConstants, there is a bug which will cause int64 overflow and let LODA crash.
There is a program which affected by this bug

mov $0,9223372036854775808
mov $1,9999999999999999999
mov $2,13043817825332782212

@loader3229
loader3229 requested a review from ckrause as a code owner June 25, 2026 17:41
ckrause
ckrause approved these changes Jun 26, 2026
View reviewed changes

@ckrause ckrause left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckrause
ckrause merged commit 7fa2fe8 into loda-lang:main Jun 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckrause ckrause ckrause approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loader3229 @ckrause