Skip to content

Prefer programs with no memory ops if program is too short #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckrause merged 2 commits into from
Jul 10, 2026
Merged

Prefer programs with no memory ops if program is too short #702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f96788
commit
loader3229 Jul 1, 2026
6adaf14
commit
loader3229 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/mine/checker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,16 @@ bool isSimpler(const Program& existing, const Program& optimized) {
} else if (!hasIndirectOperand(existing) && hasIndirectOperand(optimized)) {
return false;
}
// Prefer programs with no memory ops if program is too short
if (optimized.ops.size() <= 8 && existing.ops.size() <= 8) { // magic number
bool optimized_has_memory_op = ProgramUtil::hasRegionOperation(optimized);
bool existing_has_memory_op = ProgramUtil::hasRegionOperation(existing);
if (!optimized_has_memory_op && existing_has_memory_op && !optimized_has_seq) {
return true;
} else if (!existing_has_memory_op && optimized_has_memory_op && !existing_has_seq) {
return false;
}
}
return false;
}

Expand Down
Loading