feat(prerelease-setup): cover remaining setup gaps for loft-enterprise consumer (v1.1)#152
Merged
Merged
Conversation
…nterprise consumer Patches the composite action so the upcoming loft-enterprise Step 2 consumer PR (ENGQA-1042) can drop the inline setup block in prerelease-checks.yaml without re-introducing workarounds: - AWS Login: set output-credentials: true so consumer steps (run-ginkgo) can read AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY / AWS_SESSION_TOKEN via env.AWS_*. - Resolve step: add "empty -> latest pre-release" resolver for standalone-vcluster-upgrade-version, and "empty -> latest stable" resolver for platform-base-version. Both inputs are now optional with the same fallback semantics the pre-extraction inline workflow had. - Resolve step: mirror resolved versions to $GITHUB_ENV (STANDALONE_VCLUSTER_VERSION, STANDALONE_VCLUSTER_UPGRADE_VERSION, PLATFORM_BASE_VERSION, PLATFORM_RC_VERSION, DEFAULT_VCLUSTER_CHART_VERSION) alongside the existing $GITHUB_OUTPUT writes. Downstream steps that read these as env vars (Summarize, Run pre-release ...) keep working unchanged. - New "Verify release assets" step: HEADs the install-standalone.sh (base + upgrade) and vcluster-linux-amd64 (upgrade) URLs and fails fast before downstream EC2 / VCI provisioning if a release is missing assets. README updated to match. Tag as prerelease-setup/v1.1 after merge.
sydorovdmytro
requested changes
Jun 9, 2026
…EAD, semver guard) - Remove output-credentials: true. configure-aws-credentials exports AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY / AWS_SESSION_TOKEN to $GITHUB_ENV by default; output-credentials only controls additional step-output exposure (steps.X.outputs.aws-session-token) and has nothing to do with the env-var path the consumer actually uses. The previous reasoning in the code comment was wrong; both flag and comment are dropped. - Verify release assets: use HEAD (curl -sfIL) instead of GET so the ~50 MB vcluster-linux-amd64 body is not downloaded just to probe the URL. - Resolve step: reject an older-branch pre-release as the upgrade target (e.g. base=0.34.1, latest pre-release=0.33.5-rc.1). sort -V puts the higher semver last; the upgrade input must equal that tail. Apply the same guard to RC vs BASE on the platform side — same bug class, same fix. - README + action description updated to match.
sort -V ranks a pre-release after its release (4.9.0-alpha.1 > 4.9.0), the opposite of semver, so the newer-than guards wrongly accepted a same-version pre-release as a valid upgrade target. Map the semver '-' separator to '~' before sort -V, which treats '~' as lower than everything, restoring correct pre-release precedence. Verified on GNU coreutils 8.32 (ubuntu-latest).
sydorovdmytro
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #148. Closes gaps surfaced while wiring up the
loft-enterpriseconsumer.Tag as
prerelease-setup/v1.1after merge.Linear: ENGQA-1096