Skip to content

fix(prerelease-setup): remove ${{ }} expression from github-token input description#154

Open
sowmyav27 wants to merge 2 commits into
loft-sh:mainfrom
sowmyav27:fix-token-desc
Open

fix(prerelease-setup): remove ${{ }} expression from github-token input description#154
sowmyav27 wants to merge 2 commits into
loft-sh:mainfrom
sowmyav27:fix-token-desc

Conversation

@sowmyav27

Copy link
Copy Markdown
Contributor

What

Reword the github-token input description in prerelease-setup/action.yml so it no longer contains a literal ${{ github.token }} expression.

Why

GitHub evaluates every ${{ }} expression in an action manifest, including inputs.*.description. The github context is not available in that position, so the manifest fails template validation at load time:

loft-sh/github-actions/.github/actions/prerelease-setup/action.yml (Line: 9, Col: 18):
Unrecognized named-value: 'github'. Located at position 1 within expression: github.token

Both pre-release consumer jobs in loft-enterprise (vCluster, AI Cloud) use this action as their first step, so they die at Set up job in ~4s before anything runs. This fires on every published vCluster Pro tag (e.g. the v0.35.0-rc.6 dispatch: loft-enterprise run 27443560408).

The ${{ github.token }} was only meant as example prose for the caller; the real consumption (${{ inputs.github-token }} in the steps) is unaffected.

Change

-    description: '... Pass ${{ github.token }} from a job whose permissions grant contents:read.'
+    description: '... Pass the calling job'\''s github.token from a job whose permissions grant contents:read.'

Documentation-only string; no behavior change.

After merge — required

The consumer pins @prerelease-setup/v1, which currently points at the broken commit. The prerelease-setup/v1 tag must be force-moved to the fix commit (per docs/release process: git tag -f prerelease-setup/v1 && git push origin prerelease-setup/v1 --force), otherwise the workflow keeps loading the broken pinned version.

…ut description

The github-token input description embedded the literal ${{ github.token }}
as example prose. GitHub evaluates every ${{ }} expression in an action
manifest, including input descriptions, and the 'github' context is not
available there, so the manifest failed template validation:

  Unrecognized named-value: 'github' ... github.token

Both prerelease consumer jobs (vCluster, AI Cloud) use this action as their
first step, so they died at 'Set up job' before any step ran. Reword the
example to plain text so it is not parsed as an expression.
make check-docs regenerates action READMEs from action.yml via auto-doc.
The previous commit changed the github-token input description but did not
regenerate the README, so check-docs reported drift.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants