Skip to content

Conversation

@wangsijie
Copy link
Contributor

Summary

Add general error page component.

Testing

Screenshot 2025-11-16 at 8 40 31 PM

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@github-actions
Copy link

github-actions bot commented Nov 16, 2025

COMPARE TO master

Total Size Diff 📈 +6.59 KB

Diff by File
Name Diff
packages/account-center/src/App.module.scss 📈 +106 Bytes
packages/account-center/src/App.tsx 📈 +687 Bytes
packages/account-center/src/Providers/ExperiencePageContextBridge.tsx 📈 +1.69 KB
packages/account-center/src/components/ErrorPage/index.module.scss 📈 +621 Bytes
packages/account-center/src/components/ErrorPage/index.tsx 📈 +2.58 KB
packages/account-center/src/pages/Home/index.tsx 📈 +195 Bytes
packages/experience/src/Layout/FirstScreenLayout/index.tsx 📈 +5 Bytes
packages/experience/src/Layout/FocusedAuthPageLayout/index.tsx 📈 +14 Bytes
packages/experience/src/Layout/SecondaryPageLayout/index.tsx 📈 +14 Bytes
packages/experience/src/Layout/SectionLayout/index.tsx 📈 +7 Bytes
packages/experience/src/components/BrandingHeader/index.tsx 📈 +16 Bytes
packages/experience/src/components/Button/MfaFactorButton.tsx 📈 +17 Bytes
packages/experience/src/components/Button/index.tsx 📈 +17 Bytes
packages/experience/src/components/Divider/index.tsx 📈 +17 Bytes
packages/experience/src/components/DynamicT/index.test.tsx 📈 +786 Bytes
packages/experience/src/components/DynamicT/index.tsx 📈 +992 Bytes
packages/experience/src/components/Notification/InlineNotification/index.tsx 📈 +7 Bytes
packages/experience/src/components/PageMeta/index.tsx 📈 +477 Bytes
packages/experience/src/components/TextLink/index.tsx 📈 +16 Bytes
packages/experience/src/containers/SocialLinkAccount/index.tsx 📈 +7 Bytes
packages/experience/src/pages/ErrorPage/index.tsx 📈 +14 Bytes
packages/experience/src/pages/MfaBinding/BackupCodeBinding/index.tsx 📈 +7 Bytes
packages/experience/src/pages/SwitchAccount/index.tsx 📈 +14 Bytes
packages/experience/src/shared/components/DynamicT/index.test.tsx 📈 +786 Bytes
packages/experience/src/shared/components/DynamicT/index.tsx 📈 +992 Bytes
packages/experience/src/shared/components/PageMeta/index.tsx 📈 +477 Bytes
packages/phrases-experience/src/locales/ar/account-center.ts 📈 +121 Bytes
packages/phrases-experience/src/locales/de/account-center.ts 📈 +104 Bytes
packages/phrases-experience/src/locales/en/account-center.ts 📈 +92 Bytes
packages/phrases-experience/src/locales/es/account-center.ts 📈 +105 Bytes
packages/phrases-experience/src/locales/fr/account-center.ts 📈 +99 Bytes
packages/phrases-experience/src/locales/it/account-center.ts 📈 +102 Bytes
packages/phrases-experience/src/locales/ja/account-center.ts 📈 +126 Bytes
packages/phrases-experience/src/locales/ko/account-center.ts 📈 +125 Bytes
packages/phrases-experience/src/locales/pl-pl/account-center.ts 📈 +100 Bytes
packages/phrases-experience/src/locales/pt-br/account-center.ts 📈 +110 Bytes
packages/phrases-experience/src/locales/pt-pt/account-center.ts 📈 +110 Bytes
packages/phrases-experience/src/locales/ru/account-center.ts 📈 +132 Bytes
packages/phrases-experience/src/locales/th/account-center.ts 📈 +156 Bytes
packages/phrases-experience/src/locales/tr-tr/account-center.ts 📈 +94 Bytes
packages/phrases-experience/src/locales/uk-ua/account-center.ts 📈 +132 Bytes
packages/phrases-experience/src/locales/zh-cn/account-center.ts 📈 +87 Bytes
packages/phrases-experience/src/locales/zh-hk/account-center.ts 📈 +87 Bytes
packages/phrases-experience/src/locales/zh-tw/account-center.ts 📈 +90 Bytes
pnpm-lock.yaml 📈 +1 Bytes

Copy link
Contributor

@xiaoyijun xiaoyijun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@wangsijie wangsijie force-pushed the wangsijie-log-12433-resolve-components-sharing branch 3 times, most recently from 683ec8d to 8456d65 Compare November 19, 2025 04:25
Base automatically changed from wangsijie-log-12433-resolve-components-sharing to master November 19, 2025 06:29
@github-actions github-actions bot added size/xl and removed size/l labels Nov 19, 2025
@wangsijie wangsijie force-pushed the wangsijie-log-12450-error-pages branch from fdec9bd to 749640d Compare November 20, 2025 01:49
@github-actions github-actions bot added size/l and removed size/xl labels Nov 20, 2025
@wangsijie wangsijie force-pushed the wangsijie-log-12450-error-pages branch from 749640d to 3ee64c0 Compare November 20, 2025 02:04
@github-actions github-actions bot added size/l and removed size/l labels Nov 20, 2025
@wangsijie wangsijie merged commit 81a6e10 into master Nov 20, 2025
43 of 44 checks passed
@wangsijie wangsijie deleted the wangsijie-log-12450-error-pages branch November 20, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants