Add Annotated support#257
Conversation
658e18f to
ff35c2c
Compare
|
I would recommend importing |
736833b to
4686736
Compare
|
Rebased, and retested. |
dairiki
left a comment
There was a problem hiding this comment.
I apologize for the delay. (Life has been crazy.)
The feature addition is a good one, I think. (Thank you!) And other than some style nits, I think it looks fine.
I think the addition of tox test configuration is long overdue. Ideally, it would be a separate PR, but since it's in here, already, I'm fine leaving it here. I do have a few comments about that.
4b8ebbf to
fae55c3
Compare
I haven't had time since either, so I get it. Thank you for taking the time to review it! |
|
I think I've resolved all issues. The PR is ready for review again. |
dairiki
left a comment
There was a problem hiding this comment.
In my local dev environment, I'm having a few issues with the tox.ini.
Otherwise, LGTM.
|
I've removed |
Somehow, the line-endings in README got switched to DOS (CRLF) rather than UNIX (LF). That resulted in an unreadable diff.
|
Merged. Thank you, @mvanderlee ! I tried to make a new PyPI release (8.7.0) but #270 happened. |
|
Now released in 8.7.0. |
Fixes #256
Moving away from
NewTypeand instead addAnnotatedsupport.