-
Notifications
You must be signed in to change notification settings - Fork 670
Vendor in latest OpenTitan IPs #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
ae0ff62
49d6cd8
f2da3ff
b661da9
94578ce
8b5016b
9e1f6b6
ba8bab7
447fc64
5fee567
76620cd
ffdc5ca
024d637
b5a407f
8f546cc
72ca41c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,19 +10,9 @@ filesets: | |
| depend: | ||
| - lowrisc:ibex:ibex_pkg | ||
| - lowrisc:ibex:ibex_core | ||
| - lowrisc:prim:buf | ||
| - lowrisc:prim:clock_gating | ||
| - lowrisc:prim:secded | ||
| - lowrisc:prim:assert | ||
| - lowrisc:prim:ram_1p_pkg | ||
| - lowrisc:prim_generic:buf | ||
| - lowrisc:prim_generic:clock_gating | ||
| files: | ||
| - ../../rtl/ibex_register_file_ff.sv # generic FF-based | ||
| - ../../rtl/ibex_register_file_fpga.sv # FPGA | ||
| - ../../rtl/ibex_register_file_latch.sv # ASIC | ||
| - ../../rtl/ibex_top.sv | ||
| file_type: systemVerilogSource | ||
| - lowrisc:ibex:ibex_top | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you been able to try this out? I'm just wondering whether the explicit dependencies were to allow the formal run to look at just a subset. The existing structure is a rather ugly way to do that, but this cleanup might break things?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ran the formal flow and so does the CI, but this was my first time running it, so I don't know whether this already covers everything. But the basic formal flow works. |
||
| - "fileset_partner ? (partner:prim_generic:all)" | ||
| - "!fileset_partner ? (lowrisc:prim_generic:all)" | ||
|
|
||
| targets: | ||
| default: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,8 +14,8 @@ dependencies = [ | |
| "hjson == 3.1.0", | ||
| "mako == 1.1.6", | ||
| "pyyaml == 6.0.2", | ||
| "edalize @ git+https://github.com/lowRISC/[email protected]", | ||
| "fusesoc @ git+https://github.com/lowRISC/[email protected]", | ||
| "edalize == 0.6.1", | ||
| "fusesoc == 2.4.3", | ||
| "psutil>=7.0.0", | ||
| ] | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't squash PRs, should this commit be squashed with the previous one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I was wondering whether we should squash this PR before merging. For the review, it's great to have many but smaller commits, but once we've merged this, there will be no point in having individual commits. If we're ever going to revert one of these commits again (e.g. to debug a new failure), we'll have to revert all of them. Otherwise nothing will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I kept a lot of small commits to keep visibility of all the small things changing with the new prims and fusesoc, but I am happy to squash them all. Or maybe squash all the fuesoc related ones and the vendor related ones into two commits.