[dv] V1 signoff for GPIO block - #611
Merged
Merged
Conversation
martin-velay
marked this pull request as ready for review
June 16, 2026 13:45
KinzaQamar
reviewed
Jun 16, 2026
KinzaQamar
reviewed
Jun 16, 2026
martin-velay
force-pushed
the
gpio_v1_signoff
branch
from
June 16, 2026 15:27
213a2d3 to
d30f147
Compare
KinzaQamar
approved these changes
Jun 17, 2026
KinzaQamar
left a comment
KinzaQamar
left a comment
Contributor
There was a problem hiding this comment.
I am not super familiar with signoffs but approving as this looks sensible to me
Contributor
Author
|
@tchilikov-semify, we need 3 reviewers for the signoffs. Could you take a look? Basically, you need to double check if what I said is true and see if it's clear enough. |
tchilikov-semify
approved these changes
Jun 18, 2026
tchilikov-semify
left a comment
tchilikov-semify
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Some comments from my end.
martin-velay
force-pushed
the
gpio_v1_signoff
branch
2 times, most recently
from
June 18, 2026 14:58
c6944e4 to
690aeda
Compare
marnovandermaas
requested changes
Jun 20, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Let's wait until GPIO D1 sign-off is done before merging this.
Closed
tchilikov-semify
force-pushed
the
gpio_v1_signoff
branch
from
September 28, 2026 08:50
690aeda to
20a315a
Compare
Collaborator
|
Updated the PR to rebase from the D1 signoff of the GPIO. Now that D1 signoff is complete, this PR should be safe to merge. |
marnovandermaas
approved these changes
Sep 29, 2026
Signed-off-by: martin-velay <mvelay@lowrisc.org>
tchilikov-semify
force-pushed
the
gpio_v1_signoff
branch
from
September 29, 2026 16:30
20a315a to
4a47059
Compare
Collaborator
|
Needed one more rebase after some recent merges to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close issue #164