Conversation
PRugg-Cap
commented
Sep 18, 2026
PRugg-Cap
commented
Sep 18, 2026
PRugg-Cap
commented
Sep 18, 2026
PRugg-Cap
commented
Sep 18, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
I left some initial comments here, please address the TODOs as best you can. The CHERI register documentation, ROM additions, etc. can be deferred to D2. Please also mark this as ready to review once the TODOs are done.
PRugg-Cap
force-pushed
the
pdr32-debug-module-d1-signoff
branch
3 times, most recently
from
September 23, 2026 18:47
7afd5d5 to
92c1330
Compare
PRugg-Cap
marked this pull request as ready for review
September 23, 2026 18:48
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
No compilation errors on the assert known, just a small comment.
PRugg-Cap
force-pushed
the
pdr32-debug-module-d1-signoff
branch
from
September 24, 2026 11:32
92c1330 to
1a19e58
Compare
marnovandermaas
approved these changes
Sep 24, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
One minor comment from my end but otherwise looks good to me. Thanks for putting this together. Let's wait for 3 approvers before merging.
PRugg-Cap
force-pushed
the
pdr32-debug-module-d1-signoff
branch
from
September 24, 2026 15:10
1a19e58 to
4a04834
Compare
tchilikov-semify
self-requested a review
September 25, 2026 10:38
PRugg-Cap
force-pushed
the
pdr32-debug-module-d1-signoff
branch
from
September 25, 2026 16:25
4a04834 to
8301855
Compare
Update code from upstream repository https://github.com/pulp- platform/riscv-dbg to revision 358f90110220adf7a083f8b65d157e836d706236 Signed-off-by: Peter Rugg <peter.rugg@capabilitieslimited.co.uk>
PRugg-Cap
force-pushed
the
pdr32-debug-module-d1-signoff
branch
4 times, most recently
from
September 25, 2026 17:06
c2618e2 to
53702c9
Compare
tchilikov-semify
approved these changes
Sep 28, 2026
tchilikov-semify
left a comment
tchilikov-semify
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the updates @PRugg-Cap, LGTM!
PRugg-Cap
force-pushed
the
pdr32-debug-module-d1-signoff
branch
from
September 28, 2026 11:59
53702c9 to
5a090c9
Compare
martin-velay
self-requested a review
September 28, 2026 12:20
martin-velay
approved these changes
Sep 28, 2026
martin-velay
left a comment
martin-velay
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for this work
Collaborator
|
Hey @PRugg-Cap, thanks for the work. We're ready to merge this PR now. Before we do, could you do a rebase and resolve the minor conflict which arose from merging the CVA6 singoff? Then we should be ready to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.