Fix and minimal refactoring of the master build#73
Open
romnn wants to merge 10 commits intolukasmartinelli:masterfrom
Open
Fix and minimal refactoring of the master build#73romnn wants to merge 10 commits intolukasmartinelli:masterfrom
romnn wants to merge 10 commits intolukasmartinelli:masterfrom
Conversation
Errors are properly logged to stderr and github.com/codegangsta/cli was replaced by github.com/urfave/cli. This includes the open pull request at lukasmartinelli#67
Replaces github.com/codegangsta/cli with github.com/urfave/cli
Additionally, obsolete sudo parameter was removed and linux was set explicitly
|
Can we merge this? |
|
Bump +1 |
|
For anybody perusing these PRs. This code does build and run from source. You need to do a git clone and local build rather than a direct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following:
github.com/codegangsta/cliwith the newgithub.com/urfave/cli/v2Best, Roman