Fix libxml failure by kwkwan · Pull Request #39 · lutaml/moxml

kwkwan · 2025-11-18T01:38:02Z

No description provided.

+    name: Test Windows Setup Scripts
+    runs-on: windows-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['3.2']
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Setup Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: false
+
+    - name: Verify MSYS2 Installation
+      shell: pwsh
+      run: |
+        if (Test-Path "C:\msys64") {
+          Write-Host "✓ MSYS2 found at C:\msys64"
+        } else {
+          Write-Host "✗ MSYS2 not found"
+          exit 1
+        }
+
+    - name: Install libxml2 via MSYS2
+      shell: cmd
+      run: |
+        # C:\msys64\usr\bin\pacman.exe -S --needed --noconfirm mingw-w64-x86_64-libxml2 mingw-w64-x86_64-libiconv mingw-w64-x86_64-zlib
+
+        C:\msys64\usr\bin\pacman.exe -S --needed --noconfirm mingw-w64-ucrt-x86_64-libxml2 mingw-w64-ucrt-x86_64-libiconv mingw-w64-ucrt-x86_64-zlib
+
+    - name: Set Environment Variables
+      shell: pwsh
+      run: |
+        $rubyPlatform = ruby -e "puts RUBY_PLATFORM"
+        Write-Host "Ruby platform: $rubyPlatform"
+
+        # $envPath = "C:\msys64\mingw64"
+        $envPath = "C:\msys64\ucrt64"
+
+        echo "ICONV_INCLUDE=$envPath\include" >> $env:GITHUB_ENV
+        echo "WINDOWS_XML2_INCLUDE=$envPath\include\libxml2" >> $env:GITHUB_ENV
+        echo "WINDOWS_XML2_LIB=$envPath\lib" >> $env:GITHUB_ENV
+        echo "MSYS2_PATH=$envPath" >> $env:GITHUB_ENV
+
+        # Set PATH to include MSYS2 bin directory for DLL resolution
+        $rubyBin = ruby -e "puts RbConfig::CONFIG['bindir']"
+        Write-Host "Ruby bin directory: $rubyBin"
+        Write-Host "PATH environment variable: $env:Path"
+        $env:Path += ";$envPath;$envPath\lib;$envPath\include;$envPath\include\libxml2;$rubyBin"
+        echo "PATH=$env:Path" >> $env:GITHUB_ENV
+        Write-Host "PATH environment variable: $env:Path"
+
+        Write-Host "Environment variables set:"
+        Write-Host "  ICONV_INCLUDE=$envPath\include"
+        Write-Host "  WINDOWS_XML2_INCLUDE=$envPath\include\libxml2"
+        Write-Host "  WINDOWS_XML2_LIB=$envPath\lib"
+        Write-Host "  PATH=$env:Path"
+
+    - name: Install libxml-ruby
+      shell: pwsh
+      run: |
+        Write-Host "ICONV_INCLUDE=$env:ICONV_INCLUDE"
+        Write-Host "WINDOWS_XML2_INCLUDE=$env:WINDOWS_XML2_INCLUDE"
+        Write-Host "WINDOWS_XML2_LIB=$env:WINDOWS_XML2_LIB"
+        Write-Host "MSYS2_PATH=$env:MSYS2_PATH"
+
+        Write-Host "Files in $env:ICONV_INCLUDE are"
+        dir -Path $env:ICONV_INCLUDE | ForEach-Object {
+          Write-Host $_.Name
+        }
+
+        Write-Host "Files in $env:WINDOWS_XML2_INCLUDE are"
+        dir -Path $env:WINDOWS_XML2_INCLUDE | ForEach-Object {
+          Write-Host $_.Name
+        }
+
+        Write-Host "Files in $env:WINDOWS_XML2_LIB are"
+        dir -Path $env:WINDOWS_XML2_LIB | ForEach-Object {
+          Write-Host $_.Name
+        }
+
+        Write-Host "Files in $env:MSYS2_PATH are"
+        dir -Path $env:MSYS2_PATH | ForEach-Object {
+          Write-Host $_.Name
+        }
+
+        $rubyPlatform = ruby -e "puts RUBY_PLATFORM"
+        Write-Host "Installing libxml-ruby for $rubyPlatform..."
+
+        gem install libxml-ruby --version 5.0.4 -- --with-xml2-include=$env:WINDOWS_XML2_INCLUDE --with-xml2-lib=$env:WINDOWS_XML2_LIB --with-xml2-dir=$env:MSYS2_PATH  --with-iconv-include=$env:ICONV_INCLUDE
+
+        gem which libxml-ruby
+        $libxmlrubyfilepath = gem which libxml-ruby
+        $libxmlrubyfolder = Split-Path -Path $libxmlrubyfilepath -Parent
+        Write-Host "Folder of libxml-ruby is $libxmlrubyfolder"
+
+        Write-Host "Files in $libxmlrubyfolder are"
+        dir -Path "$libxmlrubyfolder/3.2" | ForEach-Object {
+          Write-Host $_.Name
+        }
+
+        if ($LASTEXITCODE -eq 0) {
+          Write-Host "✓ libxml-ruby installed successfully"
+        } else {
+          Write-Host "✗ Failed to install libxml-ruby"
+          exit 1
+        }
+
+    - name: Copy Required DLLs
+      shell: pwsh
+      run: |
+        $msys2Path = $env:MSYS2_PATH
+        $rubyBin = ruby -e "puts RbConfig::CONFIG['bindir']"
+
+        $sourcedir = "$msys2Path\bin"
+        Write-Host "Files in $sourcedir are:"
+        dir -Path $sourcedir -File | ForEach-Object {
+          Write-Host $_.Name
+        }
+
+        Write-Host "Copying DLLs from $msys2Path\bin to $rubyBin..."
+        $dlls = @("libxml2-16.dll", "libiconv-2.dll", "zlib1.dll")
+        foreach ($dll in $dlls) {
+          $source = "$msys2Path\bin\$dll"
+          $dest = "$rubyBin\$dll"
+
+          if (Test-Path $source) {
+            Copy-Item $source $dest -Force
+            Write-Host "✓ Copied $dll"
+          } else {
+            Write-Host "✗ $dll not found at $source"
+          }
+        }
+
+    - name: Test libxml-ruby Installation
+      shell: pwsh
+      run: |
+        Write-Host "Inspec PATH environment variable: $env:Path"
+
+        ruby -e @"
+        require 'libxml'
+        puts "libxml-ruby version: #{LibXML::XML::VERSION}"
+        puts "libxml2 version: #{LibXML::XML::LIBXML_VERSION}"
+
+        # Test basic parsing
+        doc = LibXML::XML::Document.string('<root><child attr="value"/></root>')
+        puts "Root element: #{doc.root.name}"
+        puts "Child element: #{doc.root.child.name}"
+        puts "Attribute value: #{doc.root.child['attr']}"
+        puts ""
+        puts "✓ libxml-ruby is working correctly!"
+        "@
+
+    - name: Test Moxml with LibXML Adapter
+      shell: pwsh
+      run: |
+        bundle install
+
+        ruby -e @"
+        require 'moxml'
+
+        # Configure to use LibXML adapter
+        Moxml.configure do |config|
+          config.adapter = :libxml
+        end
+
+        # Create a document
+        doc = Moxml.new.create_document
+        root = doc.create_element('root')
+        doc.add_child(root)
+
+        child = doc.create_element('child')
+        child['attr'] = 'value'
+        child.text = 'Hello from Windows!'
+        root.add_child(child)
+
+        puts "Document created with LibXML adapter:"
+        puts doc.to_xml(indent: 2)
+        puts ""
+        puts "✓ Moxml with LibXML adapter is working on Windows!"
+        "@
+
+        bundle exec rake


In general, the fix is to explicitly declare a permissions: block either at the workflow root (applies to all jobs) or within the specific job. Since there is only one job and it only needs to check out the repository, the minimal permission contents: read is sufficient, and can be set at the workflow level to make intent clear.

The single best fix without changing any current behavior is to add a top-level permissions: section after the on: block and before jobs:. This will constrain the default GITHUB_TOKEN to read-only access to repository contents, which is enough for actions/checkout@v4 and the rest of the steps that simply run commands against the checked-out code. No imports or additional methods are needed; this is a pure YAML configuration change in .github/workflows/windows.yml.

Concretely: in .github/workflows/windows.yml, insert:

permissions: contents: read

between the existing on: configuration (lines 3–7) and the jobs: key (line 9).

kwkwan linked an issue Nov 18, 2025 that may be closed by this pull request

libxml fails to run properly on Windows (Ruby 3.1, Ruby 3.4) #38

Open

kwkwan force-pushed the fix-libxml-failure-on-windows branch 24 times, most recently from f1c4f18 to b093d3b Compare November 19, 2025 05:27

Fix libxml failure

199f0fd

kwkwan force-pushed the fix-libxml-failure-on-windows branch from b093d3b to 199f0fd Compare November 19, 2025 05:51

ronaldtse requested a review from Copilot November 24, 2025 04:15

Copilot started reviewing on behalf of ronaldtse November 24, 2025 04:15 View session

Copilot finished reviewing on behalf of ronaldtse November 24, 2025 04:16

kwkwan force-pushed the fix-libxml-failure-on-windows branch 23 times, most recently from 0687768 to cfb2b91 Compare February 13, 2026 07:09

github-advanced-security AI found potential problems Feb 13, 2026

View reviewed changes

kwkwan force-pushed the fix-libxml-failure-on-windows branch 4 times, most recently from 8493a2a to 051c767 Compare February 13, 2026 08:15

Test libxml2 install

fe79ac8

kwkwan force-pushed the fix-libxml-failure-on-windows branch from 051c767 to fe79ac8 Compare February 13, 2026 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix libxml failure#39

Fix libxml failure#39
kwkwan wants to merge 2 commits intomainfrom
fix-libxml-failure-on-windows

kwkwan commented Nov 18, 2025

Uh oh!

Check warning

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

@@ -6,6 +6,9 @@
               pull_request:
               workflow_dispatch:
+            permissions:
+              contents: read
             jobs:
               test-windows-scripts:
                 name: Test Windows Setup Scripts

Conversation

kwkwan commented Nov 18, 2025

Uh oh!

Check warning

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants