Add basic ros examples #779
Conversation
jz592058
left a comment
jz592058
left a comment
There was a problem hiding this comment.
Ran all the apps and all the topics seem to be working ok (I can subscribe to their topic on my host PC), I haven't tested actually adding my own packages in the ros_driver_custom_package.
also to see the topic on my computer i needed to switch to Cyclone DDS with:
sudo apt install ros-$ROS_DISTRO-rmw-cyclonedds-cpp
export RMW_IMPLEMENTATION=rmw_cyclonedds_cpp
maybe something to add to troubleshooting of the README?
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
I mainly reviewed the overall structure and left some comments in regards to that.
Can these examples also run in peripheral mode? Can they run in both RVC2 and RVC4? Let's extand this README with these examples and fill out the additional information
change app versions to 0.9.0
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
LGTM
Only one nitpick (not blocking the merge): If possible to add a screenshort (or small GIF) to each example (under /media folder) and show it in README (e.g. check default-app for reference ) that would be quite nice!
Purpose
ROS app examples
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable