Skip to content

Conversation

@Fat-Zer
Copy link
Contributor

@Fat-Zer Fat-Zer commented Nov 3, 2024

  • add a space before "px" suffix
  • remove colons ':' in the form's labels
  • add missing colons ':' in the form's labels

@isf63
Copy link
Contributor

isf63 commented Nov 8, 2025

This looks good, granted translations would be wiped unfortunately, unless manually edited (which is a hassle.)

Apart from that, this has merge conflicts that need to be resolved before being able to merge.

@isf63
Copy link
Contributor

isf63 commented Nov 8, 2025

Actually I was confused: labels of actionable widgets (apart from QGroupBox) should have colons.

@Fat-Zer
Copy link
Contributor Author

Fat-Zer commented Nov 8, 2025

Actually I was confused: labels of actionable widgets (apart from QGroupBox) should have colons.

As for now most of them don't have colons, so‌ I've assumed it was the preferred style. I can update the PR adding the missing one instead if you wish.

@isf63
Copy link
Contributor

isf63 commented Nov 8, 2025

I can update the PR adding the missing one instead if you wish.

Please do. You can refer to PCManFM-Qt's Preferences dialog to see the general convention.

Unfortunately this will result in many translations being invalidated (as the entire string is used in tr(...)), and will require manual changes. As there are many missing colons this will be quite cumbersome.

" px" is used in PCManFM-Qt and probably is the correct string.

- add a space before "px" suffix
- add missing colons ':' in the form's labels
@Fat-Zer
Copy link
Contributor Author

Fat-Zer commented Nov 9, 2025

done

Unfortunately this will result in many translations being invalidated (as the entire string is used in tr(...)), and will require manual changes. As there are many missing colons this will be quite cumbersome.

Well... that's expected expenses of gettext-like translations.

" px" is used in PCManFM-Qt and probably is the correct string.

There is already yet another line edit with " px" suffix, so it should catch up automatically even without the rest of lxqt.

@stefonarch
Copy link
Member

stefonarch commented Nov 9, 2025

I managed to preserve translations in lxqt-session, will look into it. Don't merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants