Skip to content

require three ASCII digits for the response status code #9731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basavaraj-sm05 wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −6
Open

require three ASCII digits for the response status code #9731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6295e5
require three ASCII digits for the response status code
basavaraj-sm05 Aug 27, 2026
1c8e851
parse the status code chars in place without a substring
basavaraj-sm05 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/http/StatusLine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,18 @@ class StatusLine(
throw ProtocolException("Unexpected status line: $statusLine")
}

// Parse response code like "200". Always 3 digits.
// Parse response code like "200". Always 3 ASCII digits.
if (statusLine.length < codeStart + 3) {
throw ProtocolException("Unexpected status line: $statusLine")
}
val code =
statusLine.substring(codeStart, codeStart + 3).toIntOrNull()
?: throw ProtocolException(
"Unexpected status line: $statusLine",
)
var code = 0
for (i in codeStart until codeStart + 3) {
val digit = statusLine[i]
if (digit !in '0'..'9') {
throw ProtocolException("Unexpected status line: $statusLine")
}
code = code * 10 + (digit - '0')
}

// Parse an optional response message like "OK" or "Not Modified". If it
// exists, it is separated from the response code by a space.
Expand Down
10 changes: 10 additions & 0 deletions okhttp/src/jvmTest/kotlin/okhttp3/internal/http/StatusLineTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,16 @@ class StatusLineTest {
assertInvalid("HTTP/1.1 two")
}

@Test
fun nonAsciiDigitCode() {
// toIntOrNull() honors a sign prefix and any Unicode decimal digit, so a status code such
// as "+99", "-12" or the Arabic-Indic "٢٠٠" would otherwise be accepted even though
// RFC 9112 defines status-code as three ASCII DIGIT.
assertInvalid("HTTP/1.1 +99 OK")
assertInvalid("HTTP/1.1 -12 OK")
assertInvalid("HTTP/1.1 ٢٠٠ OK")
}

@Test
fun truncated() {
assertInvalid("")
Expand Down
Loading