Repository navigation
fix(ndt7): enumerate TCPInfo/BBRInfo fields to match legacy BigQuery order - #433
Merged
Merged
Conversation
Coverage Report for CI Build 26833216177Coverage increased (+0.5%) to 76.444%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
De-embed
tcp.LinuxTCPInfo/inetdiag.BBRInfoin the ndt7 model and enumerate their fields explicitly, ordered to reproduce the legacy ndt7 BigQuery table; reorderMeasurementto[AppInfo, BBRInfo, TCPInfo, ConnectionInfo]. AddsNewTCPInfo/NewBBRInfoconstructors; the measurer uses them.bigquery.InferSchemapreviously emittedTCPInfo.ElapsedTimelast (an artifact of embedding + a trailing field), so newly-autoloaded ndt7 tables diverged from the legacy parser table's nested field order.UNION ALL [BY NAME]coerces nested structs positionally, silently corruptingTCPInfovalues (m-lab/etl-schema#195). Explicit enumeration makes the generated schema match the legacy table and enforces append-new-fields-at-the-end going forward.Verification
TCPInfoorder is identical tomeasurement-lab.ndt.ndt7(55/55 fields), andMeasurementmatches[AppInfo, BBRInfo, TCPInfo, ConnectionInfo].go build ./...andgo vet ./ndt7/...pass.Part of the fix for m-lab/etl-schema#195. Follow-ups (separate PRs): deploy the schema to GCS, then recreate the existing autojoin
ndt7_rawtables.This change is