ci(docker): improve smoke test#32
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the GitHub Actions Docker smoke test script to be more robust and maintainable by simplifying Docker resource naming, improving environment-variable file handling, and strengthening health check and request diagnostics.
Changes:
- Simplifies container/network naming to
smoke,smoke-db, andsmoke. - Switches env-var file staging to a temporary directory (
mktemp -d) and cleans it up on exit. - Improves container health checking and adds a request timeout for the GraphQL probe.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dargmuesli
force-pushed
the
ci/docker/smoke-improve
branch
5 times, most recently
from
July 25, 2026 00:43
6367ac5 to
192d70e
Compare
dargmuesli
force-pushed
the
ci/docker/smoke-improve
branch
from
July 25, 2026 00:57
192d70e to
5ec82eb
Compare
|
🎉 This PR is included in version 2.2.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
.github/smoke-test.shscript to simplify container and network naming, improve environment variable handling, and enhance error handling and messaging. The main changes make the script more robust and easier to maintain.Container and network naming simplification:
postgraphile-smoke/postgraphile-smoke-dbtosmoke/smoke-db, and the network frompostgraphile-smoketosmoke.Environment variable management improvements:
env-varsdirectory with a dynamically created temporary directory (ENV_DIR) for environment variables, and updated all references accordingly.Robustness and error handling:
HEALTHCHECKand provide clearer error messages and logs on failure.Messaging and logging: