Skip to content

Conversation

@Tjitse-E
Copy link

@Tjitse-E Tjitse-E commented Nov 26, 2020

Description (*)

\Magento\InventoryCatalog\Model\ResourceModel\GetProductTypesBySkus::getResultKey doesn't work correctly when the skus are numerically identical (e.g. 100.00 and 100.000). This will result in an error when placing an order that will contain both of these products.

Fixed Issues (if relevant)

  1. It seems like this will fix: AppendReservationsAfterOrderPlacementPlugin afterPlace function doesnt work if SKU ends with a "." magento2#28662

Manual testing scenarios (*)

  1. Create products with SKU's 35.420 and 35.4200, enable MSI
  2. Add both products to the cart
  3. Try to place an order

Questions or comments

Check integration test \Magento\InventoryCatalog\Test\Integration\GetProductTypesBySkusTest::testExecuteWithSimilairNumericSkus. This test will fail without the code change in \Magento\InventoryCatalog\Model\ResourceModel\GetProductTypesBySkus::getResultKey.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

sidolov
sidolov previously approved these changes Dec 3, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 3, 2020

@magento run all tests

@sidolov
Copy link
Contributor

sidolov commented Dec 6, 2020

@magento run all tests

@sidolov sidolov changed the base branch from 1.2-develop to develop November 11, 2021 17:48
@sidolov sidolov dismissed their stale review November 11, 2021 17:48

The base branch was changed.

@engcom-Hotel engcom-Hotel moved this to Review in Progress in Inventory - Pull Request Progress Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Covered All changes in Pull Request are covered by auto-tests Progress: review

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

AppendReservationsAfterOrderPlacementPlugin afterPlace function doesnt work if SKU ends with a "."

2 participants