Fix place order error with similar sku's #3249
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
\Magento\InventoryCatalog\Model\ResourceModel\GetProductTypesBySkus::getResultKeydoesn't work correctly when the skus are numerically identical (e.g. 100.00 and 100.000). This will result in an error when placing an order that will contain both of these products.Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Check integration test
\Magento\InventoryCatalog\Test\Integration\GetProductTypesBySkusTest::testExecuteWithSimilairNumericSkus. This test will fail without the code change in\Magento\InventoryCatalog\Model\ResourceModel\GetProductTypesBySkus::getResultKey.Contribution checklist (*)