Fix PDA derivation using global pda instead of delegatedAccount

[Meesut0]

Helper instruction builders derived PDAs from a global pda variable
instead of the provided delegatedAccount parameter.

This could produce incorrect PDA addresses if the helpers are called with
a delegated account different from the global pda.

This change updates the PDA derivation to use delegatedAccount.

Summary by CodeRabbit

• Bug Fixes
  • Corrected delegation operations to properly derive account references, ensuring accurate delegation record management and instruction processing.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change modifies the test-delegation.ts integration test file to align PDA derivations with the delegatedAccount parameter. The update replaces PDA derivation function calls that previously used a pda parameter with calls using delegatedAccount. This includes adjustments to commit state, commit record, delegation record, and delegation metadata PDA functions. Additionally, undelegate-related PDA derivation now uses delegatedAccount.toBytes() instead of pda.toBytes() for buffer seed computation. The instruction creation helpers for commit, finalize, and undelegate operations were updated accordingly to maintain consistency in PDA source parameter.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/integration/tests/test-delegation.ts (1)

441-441: ⚠️ Potential issue | 🟠 Major

Mark validator writable in commit and finalize helpers.

The createCommitAccountInstruction helper at line 441 calls the CommitState instruction (discriminator 1), which performs active lamport transfers FROM the validator to the commit state account. The validator account must be marked writable.

Similarly, createFinalizeInstruction at line 477 should be updated to mark validator writable for consistency with the corresponding Rust instruction builders (dlp-api/src/instruction_builder/commit_finalize.rs), which explicitly mark the validator as writable.

Suggested patch

@@
-      { pubkey: validator, isSigner: true, isWritable: false },
+      { pubkey: validator, isSigner: true, isWritable: true },
@@
-      { pubkey: validator, isSigner: true, isWritable: false },
+      { pubkey: validator, isSigner: true, isWritable: true },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/integration/tests/test-delegation.ts` at line 441, The helper functions
createCommitAccountInstruction and createFinalizeInstruction currently mark the
validator account as isWritable: false but the on-chain CommitState
(discriminator 1) and corresponding finalize instruction transfer lamports from
the validator, so update both helpers to mark the validator account as writable
(set isWritable: true) where the validator is passed in (reference symbols
createCommitAccountInstruction, createFinalizeInstruction and the validator
account tuple { pubkey: validator, ... }) to match the Rust instruction builders
in commit_finalize.rs.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@tests/integration/tests/test-delegation.ts`:
- Line 441: The helper functions createCommitAccountInstruction and
createFinalizeInstruction currently mark the validator account as isWritable:
false but the on-chain CommitState (discriminator 1) and corresponding finalize
instruction transfer lamports from the validator, so update both helpers to mark
the validator account as writable (set isWritable: true) where the validator is
passed in (reference symbols createCommitAccountInstruction,
createFinalizeInstruction and the validator account tuple { pubkey: validator,
... }) to match the Rust instruction builders in commit_finalize.rs.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ff27bb1d-2dcf-40ff-8505-4a74f6d9bd5e

📥 Commits

Reviewing files that changed from the base of the PR and between 78a5d0f and fb2b51d.

📒 Files selected for processing (1)

• tests/integration/tests/test-delegation.ts