Improve old settings LEAFLET_CONFIG deprecation and migration - #427
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the transition away from legacy LEAFLET_CONFIG by refining when deprecation warnings are emitted and expanding the migration logic that seeds base/overlay layers into the database.
Changes:
- Adjust the system check to only warn about
LEAFLET_CONFIGwhen it is actually non-empty. - Extend
migrate_tilesto handle overlays and normalize scheme-less (//…) tile URLs. - Bump the dev version and document the changes in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
mapentity/VERSION |
Marks the working version as 9.0.1+dev. |
mapentity/signals.py |
Updates LEAFLET_CONFIG → DB migration logic (adds overlays, URL normalization, model name change). |
mapentity/checks.py |
Changes deprecation warning emission to only trigger when LEAFLET_CONFIG has content. |
CHANGES.md |
Documents the new behavior for the dev version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…tion from LEAFLET_CONFIG
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 92.39% 92.44% +0.05%
==========================================
Files 34 34
Lines 3075 3096 +21
==========================================
+ Hits 2841 2862 +21
Misses 234 234 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…L scheme correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ogic