Skip to content

Improve old settings LEAFLET_CONFIG deprecation and migration - #427

Merged
submarcos merged 6 commits into
mainfrom
improve_layer_creation
Jul 20, 2026
Merged

Improve old settings LEAFLET_CONFIG deprecation and migration#427
submarcos merged 6 commits into
mainfrom
improve_layer_creation

Conversation

@submarcos

Copy link
Copy Markdown
Member

…ogic

Copilot AI review requested due to automatic review settings July 20, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the transition away from legacy LEAFLET_CONFIG by refining when deprecation warnings are emitted and expanding the migration logic that seeds base/overlay layers into the database.

Changes:

  • Adjust the system check to only warn about LEAFLET_CONFIG when it is actually non-empty.
  • Extend migrate_tiles to handle overlays and normalize scheme-less (//…) tile URLs.
  • Bump the dev version and document the changes in the changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
mapentity/VERSION Marks the working version as 9.0.1+dev.
mapentity/signals.py Updates LEAFLET_CONFIG → DB migration logic (adds overlays, URL normalization, model name change).
mapentity/checks.py Changes deprecation warning emission to only trigger when LEAFLET_CONFIG has content.
CHANGES.md Documents the new behavior for the dev version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread mapentity/signals.py Outdated
Comment thread mapentity/signals.py
Comment thread mapentity/signals.py
Comment thread mapentity/signals.py Outdated
Comment thread mapentity/checks.py
Comment thread CHANGES.md Outdated
submarcos and others added 4 commits July 20, 2026 15:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (333f09a) to head (614b5d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   92.39%   92.44%   +0.05%     
==========================================
  Files          34       34              
  Lines        3075     3096      +21     
==========================================
+ Hits         2841     2862      +21     
  Misses        234      234              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@submarcos
submarcos merged commit bf4307b into main Jul 20, 2026
12 checks passed
@submarcos
submarcos deleted the improve_layer_creation branch July 20, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants