Malloy-DB-Publisher: Rename Projects to Environments and Increase Timeouts - #2773
Open
sagarswamirao wants to merge 11 commits into
Open
sagarswamirao wants to merge 11 commits into
sagarswamirao wants to merge 11 commits into
Conversation
sagarswamirao
commented
Apr 21, 2026
sagarswamirao
commented
Contributor
- Renamed Projects -> Environments
- Increased Timeouts from 10 -> 60 mins
- Updated API documentation to replace 'projects' with 'environments' for lifecycle management, including creation, configuration, and deletion. - Modified connection handling in the PublisherConnection class to use 'environmentName' instead of 'projectName'. - Adjusted integration tests to reflect changes in API endpoints and connection URIs. - Introduced new interfaces for Azure connections and expanded the AttachedDatabase type to include GCS, S3, and Azure options. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…rk/publisher-update-envs Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
sagarswamirao
marked this pull request as draft
April 21, 2026 17:36
sagarswamirao
marked this pull request as ready for review
April 22, 2026 07:07
…tion - Modified the unit test for PublisherConnection to check for environmentName instead of projectName, ensuring consistency with recent refactoring of connection handling. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
- Increased the timeout value in the unit test for PublisherConnection from 10 minutes to 1 hour to better accommodate longer-running operations. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
kylenesbit
approved these changes
Apr 22, 2026
…rk/publisher-update-envs Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
This update introduces an additional `undefined` parameter in the request methods of the PublisherConnection class. Corresponding changes have been made in the unit tests to ensure proper coverage and functionality. This adjustment aims to enhance the request handling process without altering existing behavior. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
Contributor
Author
|
kylenesbit
approved these changes
May 30, 2026
This commit enhances the formatting of the unit test in `publisher_connection.unit.spec.ts` by breaking a long line into multiple lines for better readability. The functionality remains unchanged, ensuring that the test continues to validate the handling of invalid JSON responses. Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…rk/publisher-update-envs Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…rk/publisher-update-envs Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…rk/publisher-update-envs Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
…rk/publisher-update-envs Signed-off-by: Sagar Swami Rao Kulkarni <sagarswamirao@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.