Identify the serving Fly Machine in deep health - #159
Draft
bporterfield wants to merge 1 commit into
Draft
bporterfield wants to merge 1 commit into
bporterfield wants to merge 1 commit into
Conversation
Expose Fly runtime identity on the deep-health contract so a hosted rollout can distinguish the updated warm Machine from its still-live spare. Co-Authored-By: Codex <noreply@openai.com> Signed-off-by: Ben Porterfield <benporterfield@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directly testable
Why
A hosted rollout probes the tenant hostname through Fly routing. While the old spare is
still serving, a generic 200 does not prove that the updated warm Machine booted
successfully. Returning Fly's injected Machine ID lets the private rollout gate bind
health to the exact Machine it updated.
This is only the public application bridge. It does not change hosted rollout behavior by
itself.
Verification
unrelated pre-existing CLI type error at packages/cli/src/cloud/index.ts:137
Hosted rollout dependency
After merge, compose a hosted bridge image from this commit and roll every existing
hosted warm/spare pair onto it with the current rollout gate. Only then should the
separate private exact-machine gate be enabled, so rollback targets also carry this
identity contract.
Provider verification still required
Confirm on a real staging tenant that runtime.flyMachineId exactly matches the ID returned
by the Fly Machines API.