fix(server): name a file 'explores' actually lists in the tile warning's fix - #1223
Merged
Merged
Conversation
…g's fix The tile warning suggested importing the source into "index.malloy" whatever the package listed. With 'explores' naming, say, orders.malloy and the dashboard, a root index.malloy is on disk but unlisted, and importing into it publishes nothing. The example is now the first non-dashboard model the key lists, or "a file you list there" if none. The first half of the fix now says to add the declaring file and keep the existing entries, so it cannot be read as replacing the key. It does not branch on surfaceIsIndexModel() the way the held-back warning does, because that case never reaches this lint: a surface of index.malloy alone lists no dashboards/ file, so the dashboard is held back first. The test pins that, so a change to the gate that lets one through would fail here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Swirhun <james@credibledata.com>
Sha-Bang
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1206, from Nathan's re-review of
lintTilesAgainstSurface.The index.malloy case he raised can't be reached. With no
exploreskey, the surface isindex.malloyalone. Dashboards only come fromdashboards/*.malloy, and none of those are on that surface, so every dashboard is held back before the tile check runs. The held-back warning already branches onsurfaceIsIndexModel(). The test now pins this: with no key, the dashboard isn't served and there is no tile warning. If a later change to the gate lets one through, that test fails.A real problem in the same text. The fix always said "import it into a listed file such as
index.malloy". It went wrong like this:exploreslistsorders.malloyanddashboards/dash.malloy.index.malloyexists but isn't listed.index.malloy.Changes:
exploresactually lists, not counting dashboard files. If there isn't one, the text says "a file you list there".surfaceIsIndexModel().Tested:
query_boundary.spec.tspasses (26 tests), and the old wording fails the new assertions.🤖 Generated with Claude Code