-
Notifications
You must be signed in to change notification settings - Fork 36
Include Add Packages drawer
#323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bug with state management: When I select packages in the drawer, if I select a package with a certain version rather than just with auto, if I close the drawer with the 'x' or with the 'cancel' buttons, even after clicking the 'clear' button, the 'clear package modifications' and 'apply package modifications' buttons remain activated... Looking into this more: Before this issue was clear, I first considered clearing the packages that did not contain a truthy value for |
|
Another note for improvement here: when no packages are selected, the "Install selected" packages button in the |
|
Discussed this with @ktaletsk and @yane-anaconda; the consensus was to close the package drawer once the user selects "Install selected". |
…ying package versions
… pkgs are installing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new "Add Packages" drawer interface that allows users to browse and install uninstalled packages through a dedicated modal interface. The key change is removing the "Not installed" filter option from the main package list and replacing it with a button that opens a drawer showing uninstalled packages with a selection panel for batch installation.
- Added a new
CondaPkgDrawercomponent providing a modal interface for package installation - Removed the "Available" (not installed) filter from the main toolbar and package filtering logic
- Added state management for drawer visibility and handler methods for package installation workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| packages/common/src/components/CondaPkgToolBar.tsx | Added "Add Packages" button with styling and removed "Not installed" filter option |
| packages/common/src/components/CondaPkgPanel.tsx | Integrated drawer state management, added handlers for drawer operations, and conditionally renders drawer or package list based on drawer state |
| packages/common/src/components/CondaPkgDrawer.tsx | New component implementing the package installation drawer with search, selection panel, and installation workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
I've addressed the comments from the copilot review as best as I could. I also addressed some issues I noticed while manually testing. I will go ahead and merge this PR! |
Based off of #321
Uninstalled packages are now displayed after selecting an
+ Packagesbutton, which opens a drawer that lists the uninstalled packages to be searched through and lists the packages selected for install in a right panel. This PR also removes the option to view uninstalled packages, from the default packages listing.Screen.Recording.2025-11-07.at.8.22.49.PM.mov