config: refresh development environment - #66
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b3fee7da9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| next_tab = "prefix+n" | ||
| previous_tab = "prefix+p" | ||
| split_vertical = "prefix+v" | ||
| split_horizontal = "prefix+s" |
There was a problem hiding this comment.
In this config, prefix+s is assigned to horizontal splitting, but Herdr's config reference shows keys.settings defaults to prefix+s while keys.split_horizontal defaults to prefix+minus (https://herdr.dev/docs/config-reference/). Unless settings is explicitly moved or unset, this creates a duplicate binding in the default keymap, so users pressing the documented split key can get the settings action or a startup binding conflict instead of a horizontal split.
Useful? React with 👍 / 👎.
|
|
||
| ``` | ||
| $ /opt/homebrew/bin/brew install bat fd fish fzf neovim ripgrep tree-sitter-cli tmux # macOS | ||
| $ /opt/homebrew/bin/brew install bat fd fish fzf neovim ripgrep tree-sitter-cli herdr # macOS |
There was a problem hiding this comment.
The Homebrew setup command no longer installs tmux, but this commit still leaves several restored configs requiring it: init links tmux/tmux.conf and clones TPM, nvim/lua/plugins.lua sets vim.g.slime_target = "tmux", and zsh/zshrc.d/bin/ssh shells out to tmux. A fresh machine following the README will therefore restore tmux-dependent config without the binary, breaking those workflows until tmux is installed separately.
Useful? React with 👍 / 👎.
| provider package after running `./init`: | ||
|
|
||
| ```sh | ||
| NVIM_CONFIG_HOME="${XDG_CONFIG_HOME:-$HOME/.config}/nvim" |
There was a problem hiding this comment.
When these new instructions are run from a shell that does not export XDG_CONFIG_HOME, the venv is created at $HOME/.config/nvim/venv, but nvim/init.lua falls back to an empty string and probes /nvim/venv/ before setting python3_host_prog. Users following this setup path will still fail provider health checks unless they manually export XDG_CONFIG_HOME or set NVIM_PYTHON_PATH.
Useful? React with 👍 / 👎.
1 participant
Summary
Impact
The development environment can be restored more consistently on a new machine. Neovim plugin versions are reproducible, Herdr is configured alongside the existing tools, and shell startup avoids leaking project-specific direnv state into persistent sessions.
Validation
pre-commit run --all-files./initwith an isolated temporaryXDG_CONFIG_HOMEgit diff --cached --check