Skip to content

add rule for GetIsNetworkAvailable#1155

Open
omurcankaya wants to merge 4 commits into
mandiant:masterfrom
omurcankaya:GetIsNetworkAvailable-rule
Open

add rule for GetIsNetworkAvailable#1155
omurcankaya wants to merge 4 commits into
mandiant:masterfrom
omurcankaya:GetIsNetworkAvailable-rule

Conversation

@omurcankaya
Copy link
Copy Markdown

closes #1153

Copy link
Copy Markdown
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omurcankaya , I left a quick suggestion for your review.

…ity-via-getisnetworkavailable-in-dotnet.yml

Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Copy link
Copy Markdown
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omurcankaya thank you, lints are now failing, and I added a couple of change comments that I missed the first time.

@mike-hunhoff
Copy link
Copy Markdown
Collaborator

Ignore the CLA failure, I'll get that addressed on my end. Failing lint:

 check Internet connectivity in .NET
  FAIL: filename doesn't match the rule name: Rename rule file to match the rule
name, expected: "check-internet-connectivity-in-dotnet.yml", found: 
"check-internet-connectivity-via-getisnetworkavailable-in-dotnet.yml"

omurcankaya and others added 2 commits May 14, 2026 23:00
…ity-via-getisnetworkavailable-in-dotnet.yml

Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet: NetworkInterface.GetIsNetworkAvailable

2 participants