Skip to content

Adds 'component' option to notification options #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds 'component' option to notification options #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addon/services/notification-messages-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const NotificationMessagesService = ArrayProxy.extend({
const notification = Ember.Object.create({
message: options.message,
type: options.type || 'info',
component: options.component,
autoClear: (isEmpty(options.autoClear) ? getWithDefault(globals, 'autoClear', false) : options.autoClear),
clearDuration: options.clearDuration || getWithDefault(globals, 'clearDuration', 5000),
onClick: options.onClick,
Expand Down
4 changes: 3 additions & 1 deletion addon/templates/components/notification-message.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<i class="{{notificationIcon}}"></i>
</div>
<div local-class="c-notification__content">
{{#if notification.htmlContent}}
{{#if notification.component}}
{{component notification.component message=notification.message}}
{{else if notification.htmlContent}}
{{{notification.message}}}
{{else}}
{{notification.message}}
Expand Down
19 changes: 19 additions & 0 deletions tests/dummy/app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,25 @@ this.get('notifications').success('Saved successfully!');
this.get('notifications').warning('You have unsaved changes');
{{/themed-syntax}}

<h3>component</h3>
<p>A custom component may be used for rendering the message</p>

{{#themed-syntax lang="htmlbars" theme="dark" class="h5" withBuffers=false}}
&lt;h1&gt;&#123;&#123;message.title&#125;&#125;&lt;/h1&gt;
&lt;span class='count'&gt;&#123;&#123;message.count&#125;&#125;&lt;/span&gt;
{{/themed-syntax}}

{{#themed-syntax lang="js" theme="dark" class="h5" withBuffers=false}}
let message = {
title: 'You have unread messages',
count: 3,
};

this.get('notifications').info(message, {
component: 'unread-message'
});
{{/themed-syntax}}

<h3>htmlContent</h3>
<p>You can enable basic HTML markup for notification messages.</p>
<p><b>Warning:</b> This introduces a potential security risk since the notification message will no longer be escaped by Ember.</p>
Expand Down