Skip to content

docs: do not recommend implicit injection #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: do not recommend implicit injection #339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions tests/dummy/app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,7 @@ export default Controller.extend({
notifications: service(),
});</CodeBlock>

<p>Or inject it everywhere with an initializer.</p>
<CodeBlock @language="js">// app/initializers/inject-notifications.js
export function initialize(application) {
['controller', 'component', 'route'].forEach(injectionTarget => {
application.inject(injectionTarget, 'notifications', 'notification-messages:service');
});
};

export default {
name: 'inject-notifications',
initialize
};
</CodeBlock>
<p>Prior to Ember 4.0.0 it was also possible to inject it everywhere with an initializer. However, this has been <a href="https://deprecations.emberjs.com/v3.x/#toc_implicit-injections">deprecated</a> and will no longer work in Ember 4.0.0 or later.</p>

<p>There are four styles of notification available.</p>
<p class="h5"><i>Default value is info</i></p>
Expand Down Expand Up @@ -275,4 +263,4 @@ export default NotificationsService.extend({
<p class="h5">&copy; Chris Manson 2019</p>
</div>
</div>
</footer>
</footer>