fix: handle graph points sharing one pixel - #127
Merged
chrispader merged 1 commit intoAug 24, 2026
Conversation
Member
|
Thanks for the PR. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The path sampler derives an array index from the relative pixel position. With a very wide X range, flooring can map both the first and last graph points to the same pixel. The resulting endX - startX value is zero, so the computed index becomes NaN and the code reads graphData[NaN].date.
A zero-width pixel span has only one drawable pixel. The sampler now selects index zero for that degenerate case while leaving the existing interpolation unchanged for every non-zero span.
Validation
The regression test failed on main with Cannot read properties of undefined (reading date), then passed with a finite path after the guard.
Fixes #95.