CONC-749 plugins.multiauth fails on mac #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the dylib isn't found on linux, then dlerror() returns 'no such file' but on Mac it returns a lot more information. Our tests expect the string 'no such file', so detect that error on Mac and replace the text.
Member
|
"a lot more information" is usually good. If it's a useful information. Better to adjust the test to be less picky |
Member
Author
It's not really useful, just path information, which isn't available on Linux. |
Collaborator
|
I would keep this information. I don't know if multiauth is skipped or limited on windows, but we also extend the Windows system error message with path information |
Member
Author
|
I'm happy to keep it, but I'm wondering how to make the test resilient to the differences in output across operating systems, do you have advice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dylib isn't found on linux, then dlerror() returns 'no such file' but on Mac it returns a lot more information. Our tests expect the string 'no such file', so detect that error on Mac and replace the text.