PDP-1660 Making the custom GH package repo configurable#655
Merged
Conversation
rjrudin
requested review from
RitaChen609,
jonmille,
ngodugu-marklogic and
rjdew-progress
as code owners
July 22, 2026 16:10
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes GitHub Packages Maven repository usage configurable via a ghPackagesUrl project property, enabling publishing and dependency resolution in environments (e.g., GitHub Actions) that can’t access the internal Artifactory repository.
Changes:
- Make the Flux CLI publishing target GitHub Packages URL configurable via
ghPackagesUrl. - Add an optional GitHub Packages Maven repository for resolving dependencies (e.g., Spark connector) when
ghPackagesUrlis provided. - Apply the
net.saliman.propertiesplugin at the root to support property loading.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flux-cli/build.gradle | Switch publishing GitHub Packages repo from hardcoded URL to ghPackagesUrl. |
| build.gradle | Add optional dependency-resolution Maven repo for GitHub Packages and apply properties plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+334
to
338
| if (project.hasProperty("ghPackagesUrl")) { | ||
| maven { | ||
| name = "GitHubPackages" | ||
| url = uri("https://maven.pkg.github.com/rjrudin/flux") | ||
| url = uri(ghPackagesUrl) | ||
| credentials { |
RitaChen609
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.