Add support for filenames beginning with a dash#149
Open
ideoforms wants to merge 1 commit intomarl:masterfrom
Open
Add support for filenames beginning with a dash#149ideoforms wants to merge 1 commit intomarl:masterfrom
ideoforms wants to merge 1 commit intomarl:masterfrom
Conversation
Member
|
@rabitt what are your thoughts? |
Member
|
Looking at this PR again today, i feel like this program flow: if input_filepath != "-n":
args.append("--")
args.append(input_filepath)appears enough times in the PR to warrant being a pysox function of its own, with a unit test. Relatedly, does this PR support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case which requires support for filenames beginning with a dash (“-”). However, this is currently parsed as an extra argument, and causes sox/soxi to bail with an exit code of 1.
This PR addresses the issue by inserting a double-dash immediately before the filename (in input and output cases), and incorporates unit tests for these cases.
Please let me know if you have any concerns or would like any changes. Thanks for the excellent library!