feat: support runtime model index N in expressions and indexing#113
Merged
martinjrobins merged 3 commits intomainfrom Mar 8, 2026
Merged
feat: support runtime model index N in expressions and indexing#113martinjrobins merged 3 commits intomainfrom
martinjrobins merged 3 commits intomainfrom
Conversation
Owner
Author
|
need to change the API of the model_index param. Remove this from rhs, stop etc, and add it to SetInputsFunc. The model_index pass in here will be written to a global value in the codegen module, ready to be used during the other functions. So the API is (a) user sets the model index using set_inputs once, then (b) this is used in subsequent u0, rhs, stop etc functions. So N is no longer time dependent, but is not input dependent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
see #112