docs(observability): sync reasoning-aware TPS spec - #3
mastertyko wants to merge 1 commit into
Conversation
|
@codex review |
|
Superseded by upstream PR Soju06#1889. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6553642b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Requirement: Dashboard request logs show generation speed | ||
|
|
||
| The dashboard request-log table MUST show time to first token and output-token generation speed when the required latency and output-token fields are available. Generation speed MUST use output tokens divided by elapsed generation time after time to first token, not total input plus output tokens and not total request latency including TTFT. | ||
| The dashboard request-log table MUST show time to first token and output-token generation speed when the required latency and output-token fields are available. Generation speed MUST use non-reasoning output tokens divided by elapsed generation time after time to first token, not total input plus output tokens and not total request latency including TTFT. The displayed metric MUST remain named `TPS`. |
There was a problem hiding this comment.
For older rows, prematurely terminated streams, and custom model-source responses, reasoning_tokens can be null even when output tokens and timing are present. In that case the dashboard subtracts zero (frontend/src/features/dashboard/components/recent-requests-table.tsx:287) and Reports does the same via coalesce (app/modules/reports/repository.py:482), so both can include reasoning tokens despite this new unconditional non-reasoning-TPS requirement. Specify whether unknown reasoning is a missing speed input or an explicit compatibility fallback; otherwise the normative SSOT promises behavior the implementation cannot provide.
AGENTS.md reference: AGENTS.md:L44-L45
Useful? React with 👍 / 👎.
1 participant
Change
Sync the active
expand-ttft-output-eventsdelta into the main proxy-runtime-observability spec.Details
Verification
openspec validate proxy-runtime-observability --type spec --strict— validThe active delta remains available for later archival.