Skip to content

refactor: replace string formatting with url.URL to support ipv6 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masterzen merged 1 commit into from
Aug 19, 2025
Merged

refactor: replace string formatting with url.URL to support ipv6 #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions endpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package winrm

import (
"fmt"
"net"
"net/url"
"strconv"
"time"
)

Expand Down Expand Up @@ -37,7 +39,14 @@ func (ep *Endpoint) url() string {
scheme = "http"
}

return fmt.Sprintf("%s://%s:%d/wsman", scheme, ep.Host, ep.Port)
u := &url.URL{
Scheme: scheme,
Host: net.JoinHostPort(ep.Host, strconv.Itoa(ep.Port)),
Path: "/wsman",
}

return u.String()

}

// NewEndpoint returns new pointer to struct Endpoint, with a default 60s response header timeout
Expand Down
Loading