Repository navigation
get_table Improvment - #1145
Merged
tsmathis merged 1 commit intoNov 5, 2026
Merged
get_table Improvment#1145
Conversation
…ally Response time for getting larger tables was large (~10sec for ~9k rows). This was due to serial pagination. Now get_table concurrently finds all pages then assembles them into a table. This leads to a 1.8x speed-up during testing.
Collaborator
|
which table/query were you testing? |
Contributor
Author
A_Lab's tables are being loaded into an app, so I did a quick pass at speeding up loading tables. Wouldn't call this "optimzation", since I am just using concurrency to speed up the original process. Getting tables with md5s: ['b785f29bef8655ee75bfb98ec95c6022', 'f11c5e78483d8818c39bc99afa576de0', 'fdb6e4eb3f52376aa0eb5a47b2211abd'] Running on a single thread the third table took ~7 seconds. With concurrency it took ~3 seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Response time for getting larger tables was large (~10sec for ~9k rows). This was due to serial pagination. Now get_table concurrently finds all pages then assembles them into a table. This leads to a 1.8x speed-up during testing.
Major Changes
get_table now fetches pages >=2 concurrently, using page 1 to size its concurrent requests.