Repository navigation
Specify minimum version for boto3 dependency - #1147
Merged
Merged
Conversation
Updated boto3 dependency to require version 1.34 or higher.
Contributor
Author
|
(Noting again that the failing test is unrelated to this PR) |
kavanase
added a commit
to sblisesivdin/doped
that referenced
this pull request
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very minor fix to add a floor for the
boto3dependency.Summary
mp-apilistsboto3with no version bound.python-dateutil3.0.0 (2026-10-21) and 4.0.0 (2026-11-01) are nowout, and every modern
botocorerequirespython-dateutil<3.0.0. If a resolver settles on dateutil ≥ 3, it can stillsatisfy the bare
boto3requirement by going back toboto3==0.0.3(2014), which sets no upper bounds. That pulls inbotocore==0.76.0andsix==1.7.3, andimport mp_api.clientthen fails on Python ≥ 3.12:(causing all our
dopedCI to fail: https://github.com/SMTG-Bham/doped/actions/runs/42040349880).This PR adds a
boto3>=1.34floor. A modernboto3is then always selected (alongsidepython-dateutil2.9.x).Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)