Use sender instead of user_id for any stripped state event usages#1424
Closed
MadLittleMods wants to merge 1 commit into
Closed
Use sender instead of user_id for any stripped state event usages#1424MadLittleMods wants to merge 1 commit into
sender instead of user_id for any stripped state event usages#1424MadLittleMods wants to merge 1 commit into
Conversation
9 tasks
Contributor
Author
|
Closing in favor of #1425 which has the same branch name as the Synapse changes (element-hq/synapse#19723) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
senderinstead ofuser_idfor any stripped state event usagesSpawning from element-hq/synapse#19723 (where these tests started to fail) which ensures we actually use stripped state everywhere. Stripped state only has
content,sender,state_key,typeavailable. Previously, this relied on the full PDU being available which meant access touser_idas well.user_idis a deprecated field from Synapse that isn't in the spec.Dev notes
Example failure:
Testing:
Generic (from docs):