Skip to content

Use sender instead of user_id for any stripped state event usages #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MadLittleMods wants to merge 1 commit into from
Closed

Use sender instead of user_id for any stripped state event usages #1425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/30rooms/12thirdpartyinvite.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ sub can_invite_unbound_3pid
assert_json_list( $body->{invite_state}{events} );

my %members = map {
$_->{state_key} => $_
$_->{sender} => $_

@anoadragon453 anoadragon453 May 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description talks about updating user_id -> sender but the diff shows state_key -> sender?

@MadLittleMods MadLittleMods May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, totally!

This is my mistake. My original attempt did do user_id -> sender changes (#1424) but I also made too many changes and caused other errors (all manual changes). I then started over and had an LLM do a cycle of (change -> test) to find the minimum changes and it ended up here. I didn't notice it wasn't a user_id -> sender change and kept the same reasoning. Sorry for the slopped on experience.

All of that is a red herring though and it's just my naive-perl eyes spotting user_id when all of that is actually fine and the actual problem is we're dropping the inviter's membership as the error actually says. Most likely caused by this review point.

This is all unspecced behavior but is something Synapse has been doing forever and tested here so probably have to keep it going.

@MadLittleMods MadLittleMods May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as no change to Sytest is probably necessary ⏩

} grep { $_->{type} eq "m.room.member" } @{ $body->{invite_state}{events} };

exists $members{ $inviter->user_id } or die "No inviter member invite state";
Expand Down
Loading