-
Notifications
You must be signed in to change notification settings - Fork 165
Added collapsed style for issue labeled subscriptions mattermost/matt… #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello @JOAO-Ethan, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a collapsed notification style for GitHub issue labeled events. When the collapsed style is configured, issue labeled notifications display in a more compact format instead of the default expanded format with title and multiple lines.
Key Changes:
- Modified the
issueLabelledtemplate to support both collapsed and expanded notification styles
Comments suppressed due to low confidence (2)
server/plugin/template.go:1
- There are two spaces between the closing backtick and 'by'. This should be reduced to one space for consistent spacing.
// Copyright (c) 2018-present Mattermost, Inc. All Rights Reserved.
server/plugin/template.go:1
- The word 'issue-labeled' uses a hyphen while line 311 uses 'labeled' without 'issue-' prefix. Consider using consistent terminology across both style variants (either 'labeled' or 'issue-labeled' in both places) for better maintainability.
// Copyright (c) 2018-present Mattermost, Inc. All Rights Reserved.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nevyangelova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JOAO-Ethan looks good to me. Note for QA:
- Create a subscription with --render-style collapsed
/github subscribe owner/repo issues --render-style collapsed - Label an issue in GitHub
- Verify the notification in Mattermost is a single line like:
owner/repo issue #123 labeled bug by @username.
- Then repeat with expanded style
/github subscribe owner/repo issues --render-style expanded - Verify the notification shows heading format:
Issue Title
owner/repo#123
#issue-labeled enhancement by @username.
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
Added a collapsed style for labeled issue notifications.
Ticket Link
Fixes #740