Repository navigation
client: send connecting state - #27
Merged
iFixRobots merged 1 commit intoSep 25, 2026
Merged
Conversation
tulir
changed the title
tulir
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local Google Voice connection can fail while fetching the account, for example when the network temporarily cannot reach Google. The client logs
Failed to get account on connectand sendsUNKNOWN_ERRORwith the request error. When BridgeV2 is configured to reconnect after that error, it tries again later, but if the second failure has the same error text, BridgeV2 deduplicates the state before scheduling another attempt. The account remains disconnected even if the network returns afterward.I found this by tracing the account-fetch failure through
GVClient.Connectand BridgeV2's state queue.Connectcurrently sends no state between attempts, so the secondUNKNOWN_ERRORcan be identical to the first. Now it sendsCONNECTINGas an attempt starts. If that attempt fails, itsUNKNOWN_ERRORis a new transition and BridgeV2 can schedule the next reconnect; if it succeeds, normal connection reporting takes over. Bad credentials still take their existing path. This works with a host that enables BridgeV2's unknown-error reconnect policy; that configuration is a separate SDK change.