Skip to content

build(deps): hold skim at 5.1.0 — 5.3.1 breaks the picker on legacy Windows #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 1 commit into from
Jul 22, 2026
Merged

build(deps): hold skim at 5.1.0 — 5.3.1 breaks the picker on legacy Windows #3538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 108 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,12 @@ wait-timeout = "0.2"
# API, and earlier 4.x compile against an incompatible ratatui (`-Z
# minimal-versions` otherwise resolves skim 4.6 against ratatui 0.30.1 and fails
# to build).
skim = { version = "5.0", optional = true, default-features = false, features = ["frizbee"] }
# Held at 5.1.0: skim 5.3.1 (bumped in #3526) regresses the picker on the legacy
# Windows console — every picker PTY test fails with "Keyboard progressive
# enhancement not implemented for the legacy Windows API", reddening
# `test (windows)`. 5.1.0 is the last Windows-green release; unpin once the
# keyboard-enhancement path is guarded for the legacy console.
skim = { version = "=5.1.0", optional = true, default-features = false, features = ["frizbee"] }
# Pinned to skim's ratatui line so the `Line` type `display()` returns is the
# same one skim consumes. `ansi-to-tui` parses ANSI SGR codes into ratatui spans.
# Floor is 0.30.1: 0.30.0 is a broken release (its `#[instability::unstable]`
Expand Down
Loading