chore: update tend workflows (0.1.15 → 0.1.17) - #3822
Conversation
worktrunk-bot
left a comment
There was a problem hiding this comment.
Regeneration looks clean — the eight files differ from 0.1.15 only in the version pins, the reworked verify pre-check in tend-mention.yaml, and the new eyes-reaction steps. bot_name substitution is complete (the script now reads $BOT_NAME rather than a baked-in login, and the remaining literal worktrunk-bot strings are all in job/step if: expressions, where env isn't available). The new TARGET expressions resolve correctly on every event that can actually reach those steps: issue_comment is the only reachable event with github.event.comment in verify (the issues trigger has no comment, and direct pull_request_review_comment events never pass verify's if:), so the issues/comments/{id} vs pulls/comments/{id} split is right in both branches. The verify reordering is behaviour-preserving on reachable inputs — the one input class where the old and new orders diverge (a bot-authored APPROVED review carrying fresh inline comments on a bot-authored PR) can't occur, since GitHub refuses self-approval.
One thing worth knowing about the new 👀 signal, since it can't be fixed here: in tend-mention.yaml the reaction is added in the verify job but removed in handle, and handle is the only one of the two carrying a concurrency group (tend-mention-handle-<n>). cancel-in-progress: false keeps a running job alive but still evicts a pending one, so a burst of three mentions on the same thread cancels run 2's handle before it allocates a runner — and a job cancelled while queued runs no steps at all, always() included. Run 2's verify has already reacted by then, so that comment keeps a 👀 that says "session in flight" forever. tend-review.yaml and tend-triage.yaml don't have this shape: their add and remove live in the same job, so the reaction can only exist if the job that removes it started. Fix belongs upstream in tend's generator — either move the add into handle, or give verify a matching cleanup path.
Smaller, same file family: the remove steps list reactions with gh api "…/reactions?content=eyes" and no --paginate, so past 30 eyes reactions on a single issue or PR the bot's own could sit on page 2 and never be deleted. Unlikely to bite this repo.
No inline suggestions — these files carry Do not edit this file directly — it will be overwritten on regeneration, so both notes are upstream observations rather than changes to make on this branch. Not approving because this is a self-authored PR, not because of the findings; nothing here blocks the bump.
|
Routed the review's two findings upstream as max-sixty/tend#989 — the stale-👀 path (add in One correction to the review's second note: it's more likely to bite than "unlikely". Nothing to change on this branch; these files are generated and the bump is unaffected. |
Automated nightly regeneration of tend's workflow files.
tend version: 0.1.15 → 0.1.17
Notable changes
tend checkreads the bot's own bypass verdict on repos where the actor list is withheld, instead of reporting a false FAIL (check: read the bot's own bypass verdict where the actor list is withheld tend#976).Compare: max-sixty/tend@0.1.15...0.1.17