Rename depth_threshold to distinguish two unrelated uses#137
Merged
MBARIMike merged 6 commits intombari-org:mainfrom Mar 16, 2026
Merged
Rename depth_threshold to distinguish two unrelated uses#137MBARIMike merged 6 commits intombari-org:mainfrom
MBARIMike merged 6 commits intombari-org:mainfrom
Conversation
DEPTH_THRESHOLD and the depth_threshold parameter were shared across two semantically distinct roles: - add_profile(): minimum vertical displacement between adjacent depth peaks required to increment the profile counter. Renamed to PROFILE_MIN_DEPTH_CHANGE / profile_min_depth_change. - correct_biolume_proxies(): minimum depth below the surface to include data points in the fluorescence/bioluminescence proxy correction. Renamed to SURFACE_EXCLUSION_DEPTH_M / surface_exclusion_depth_m.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPTH_THRESHOLD and the depth_threshold parameter were shared across two semantically distinct roles:
add_profile(): minimum vertical displacement between adjacent depth peaks required to increment the profile counter. Renamed to PROFILE_MIN_DEPTH_CHANGE / profile_min_depth_change.
correct_biolume_proxies(): minimum depth below the surface to include data points in the fluorescence/bioluminescence proxy correction. Renamed to SURFACE_EXCLUSION_DEPTH_M / surface_exclusion_depth_m.