Apply fix such that correlations are only computed on the profile part below surface_exclusion_depth_m#139
Merged
MBARIMike merged 2 commits intombari-org:mainfrom Mar 18, 2026
Merged
Conversation
…tion logic in correct_biolume_proxies(), compute adinos threshold counts using only points deeper than surface_exclusion_depth_m compute fluo/bg_biolume correlation on the deep-only subset (and depth-limited portion) instead of full profile data update debug messaging to report deep-only adinos counts used for correction decisions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses discussion in Slack from 18 March 2026.