feat(sheet): Added back stack for StopSheet/BusSheet#84
feat(sheet): Added back stack for StopSheet/BusSheet#84iswheeler wants to merge 17 commits intomaizebus-2.1from
Conversation
Things are still VERY broken, but it kind of works right now. What's still broken * The modal decides it wants to be the entire screen height after the first click * Swiping down doesn't work yet We'll keep chipping away at it
Also figured out why the bus sheet was so jank--it made a doubly nested DraggableScrollableSheet
The two Sheets are still fighting over the same ScrollController. Unfortunate.
|
When you use Android back button, the sheet moves in from the left, whereas when you swipe the sheet to the right, the bottom sheet stays still and does not move in from the left. This is visible in the video you attached in the pull request description. |
|
Just fixed the animation. @TheStaticBits Looks like our changes ended up conflicting--apparently your changes to StopSheet made it accept a new We should be able to sort this out on Saturday, just figured I'd leave this here as a reminder/documentation |
Description
Added a back stack so users who open a stop sheet from a bus sheet (or vice versa) can swipe to go back.
Type of Change
feat)fix)Related Issues
Closes #50
Changes Made
map_screen.dartinto its own classsheet_navigation_manager.dartStopSheetandBusSheetto accept aScrollControllerfrom theSheetNavigator(to prevent issues with two sheets displayed on top of each other and fighting over the sameScrollController)DraggableScrollableSheetcontained aStopSheet, which would contain another nestedDraggableScrollableSheetdebugPrintstatements from my previous work inupcoming_stops_widget.dart(Note: The diff looks like I changed a bunch of stuff in
stop_sheet.dart, but most of that is removing the duplicateDraggableScrollableSheetand fixing the indentation. Not sure why the diff is confused about that. I also made sure this branch was up to date withmaizebus-2.1so hopefully merging should go smoothly)Testing Done
Flutter:
Screenshots / Demo (if UI or notification change)
maizebus_feature_pr.mp4
Checklist
[type](scope): short descriptionmainand is our current working update branch (e.g.maizebus2.1)print()/debugPrint()/console.log()left in production code