Skip to content

feat(ui): New button to favorites sheet and now saving buildings#85

Open
john-yang-11 wants to merge 5 commits intomaizebus-3from
savingbuildings
Open

feat(ui): New button to favorites sheet and now saving buildings#85
john-yang-11 wants to merge 5 commits intomaizebus-3from
savingbuildings

Conversation

@john-yang-11
Copy link
Copy Markdown

@john-yang-11 john-yang-11 commented Apr 9, 2026

Description

(1-2 sentences: New button to favorites sheet and now saving buildings)

Type of Change

  • New feature (feat)
  • Bug fix (fix)
  • Refactor / code improvement
  • Dependency / build update
  • Documentation
  • Other (explain)

Related Issues

Closes #XX

Changes Made

  • Flutter:
    • lib/screens/map_screen.dart, lib/util/favorite_building_storage.dart, lib/widgets/building_sheet.dart, lib/widgets/favorites_sheet.dart
  • Backend (TypeScript):
    • ...
  • Firebase / Shared:
    • ...

Testing Done

Flutter:

  • Tested on:
    • iOS Simulator
    • Android Emulator
    • Physical device

Screenshots / Demo (if UI or notification change)

Checklist

  • Commit messages follow Conventional Commits
  • PR title follows [type](scope): short description
  • PR target branch is not main and is our current working update branch (e.g. maizebus2.1)
  • No print() / debugPrint() / console.log() left in production code
  • Secrets / keys not committed

@john-yang-11 john-yang-11 changed the base branch from main to maizebus-2.1 April 9, 2026 00:47
@i-kumar i-kumar requested review from TheStaticBits, i-kumar, iswheeler and kurz3m3 and removed request for TheStaticBits April 11, 2026 03:18
Copy link
Copy Markdown
Member

@i-kumar i-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add comments to favorite_building_storage. It's a massive file with like one comment.

also can you change the base branch to maizebus-3. also can you merge maizebus-2.1 into this branch to clean up the merge conflict

@john-yang-11 john-yang-11 changed the base branch from maizebus-2.1 to maizebus-3 April 11, 2026 18:09
@john-yang-11 john-yang-11 changed the base branch from maizebus-3 to maizebus-2.1 April 11, 2026 18:33
@john-yang-11 john-yang-11 changed the base branch from maizebus-2.1 to maizebus-3 April 11, 2026 18:39
@john-yang-11 john-yang-11 requested a review from i-kumar April 11, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants